Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/508 notification with resource #517

Merged
merged 44 commits into from
May 28, 2024

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented May 8, 2024

Description

  • Changed a few model interfaces to base classes to avoid repeating properties.
  • Moved ignoreReservations and resourceId to base class => consequence: the properties will be included in all order endpoints including /status and /notifications. Do we want this, or should I move the properties to the relevant models? Have not made relevant repository changes yet.
  • New profile client to retrieve unit details
  • Updated to contact point service to use both profile client and authorization service

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@acn-sbuad acn-sbuad marked this pull request as ready for review May 23, 2024 10:14
Copy link
Member

@SandGrainOne SandGrainOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some nitpicking.

Copy link

sonarcloud bot commented May 28, 2024

@acn-sbuad acn-sbuad merged commit c01b6d7 into main May 28, 2024
7 checks passed
@acn-sbuad acn-sbuad deleted the feature/508-notification-with-resource branch May 28, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants